[CI] Remove dpctl dependency from onedal/tests/utils/_device_selection.py #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hooray, I have uncovered a seg fault in basicstats on GPU. I am going to disable the pytorch install to see if the sycl runtime is causing problems, then I am going to install dpctl instead to see if it is the runner or the code I wrote in sycl.cpp, and then that would leave only oneDAL as the cause. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
icfaust
changed the title
Contributor
Author
|
/intelci: run |
icfaust
requested review from
ahuber21,
david-cortes-intel,
ethanglaser and
yuejiaointel
as code owners
Contributor
|
/intelci: run |
Contributor
|
Failure in the public CI is due to a known bug in oneDAL, not connected to these changes. |
10 tasks
Contributor
|
Looks like this will require additional changes: |
Contributor
Author
|
/intelci: run |
Contributor
Author
|
@david-cortes-intel it should be fixed but private CI looks like a mess (not due to the PR) |
david-cortes-intel
approved these changes
Dec 10, 2025
david-cortes-intel
merged commit 6513f92
into
uxlfoundation:main
30 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generalize GPU testing to work when dpctl is unavailable, but a SYCL device is.
Depends on #2509
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing